feat: Enable automatic updates of preinstalled Snaps #37610
Merged
+31
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✨ Files requiring CODEOWNER review ✨🫰 @MetaMask/core-platform (2 files, +5 -0)
|
Collaborator
Builds ready [e71e285]
UI Startup Metrics (1228 ± 96 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [be4a143]
UI Startup Metrics (1218 ± 82 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [6db7a96]
UI Startup Metrics (1246 ± 100 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
FrederikBolding
force-pushed
the
fb/preinstalled-snaps-ota
branch
from
6db7a96 to
6469b23
Compare
Collaborator
Builds ready [6469b23]
UI Startup Metrics (1216 ± 91 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Mrtenz
reviewed
Nov 11, 2025
Comment on lines
+354
to
+355
| "database": "object", | ||
| "lastUpdated": "number", |
Member
Author
There was a problem hiding this comment.
The registry was likely not updated in these tests before because the fixture didn't have any third party Snaps. Before this PR we would only update the registry if you had a third party Snap that could have been blocked.
Mrtenz
approved these changes
Nov 11, 2025
Collaborator
Builds ready [73911c7]
UI Startup Metrics (1110 ± 92 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
mikesposito
approved these changes
Nov 11, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 11, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR adds an environment variable for automatically updating preinstalled Snaps and enables it. Following onboarding and as long as the user doesn't opt-out, the Snaps registry will be queried and used to serve updates for preinstalled Snaps. We also keep the existing condition in case the feature flag is turned off in the feature for backwards compatibility with users of third party Snaps. [](https://codespaces.new/MetaMask/metamask-extension/pull/37610?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Enable automatic updates of preinstalled Snaps <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adds an env-flagged auto-update for preinstalled Snaps and refreshes the Snaps registry after onboarding; updates tests and bumps snaps-controllers. > > - **Snaps/Controller**: > - Add `postOnboardingInitialization` logic to call `snapController.updateRegistry()` when `AUTO_UPDATE_PREINSTALLED_SNAPS` is enabled or when any non-preinstalled snap exists; remove redundant background trigger. > - Pass new feature flag `autoUpdatePreinstalledSnaps` to `SnapController` via `SnapControllerInit` (read from `process.env.AUTO_UPDATE_PREINSTALLED_SNAPS`). > - **Config**: > - Define `AUTO_UPDATE_PREINSTALLED_SNAPS: 'true'` in `builds.yml`. > - **Tests**: > - Update `snap-controller-init` test expectations to include `autoUpdatePreinstalledSnaps`. > - Adjust metrics state snapshots to expect populated `SnapsRegistry.database` and `lastUpdated`. > - **Dependencies**: > - Bump `@metamask/snaps-controllers` to `^16.1.1`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 73911c7. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-13.10.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
](https://codespaces.new/MetaMask/metamask-extension/pull/37610?quickstart=1){kind=link}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an environment variable for automatically updating preinstalled Snaps and enables it. Following onboarding and as long as the user doesn't opt-out, the Snaps registry will be queried and used to serve updates for preinstalled Snaps.
We also keep the existing condition in case the feature flag is turned off in the feature for backwards compatibility with users of third party Snaps.
Changelog
CHANGELOG entry: Enable automatic updates of preinstalled Snaps
Note
Adds an env-flagged auto-update for preinstalled Snaps and refreshes the Snaps registry after onboarding; updates tests and bumps snaps-controllers.
postOnboardingInitializationlogic to callsnapController.updateRegistry()whenAUTO_UPDATE_PREINSTALLED_SNAPSis enabled or when any non-preinstalled snap exists; remove redundant background trigger.autoUpdatePreinstalledSnapstoSnapControllerviaSnapControllerInit(read fromprocess.env.AUTO_UPDATE_PREINSTALLED_SNAPS).AUTO_UPDATE_PREINSTALLED_SNAPS: 'true'inbuilds.yml.snap-controller-inittest expectations to includeautoUpdatePreinstalledSnaps.SnapsRegistry.databaseandlastUpdated.@metamask/snaps-controllersto^16.1.1.Written by Cursor Bugbot for commit 73911c7. This will update automatically on new commits. Configure here.